Add a Makefile for convenience #8491
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #8491 +/- ##
============================================
- Coverage 17.56% 3.58% -13.98%
============================================
Files 5911 445 -5466
Lines 529359 37536 -491823
Branches 64655 6901 -57754
============================================
- Hits 92979 1347 -91632
+ Misses 425922 36025 -389897
+ Partials 10458 164 -10294
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
ah, you are from the makestory :D |
|
looks ok, I'm not sure of the use yet. can you explain the framework in use ; yarn, make. pre-commit? is this only for use in GHA? |
rohityadavcloud
left a comment
rohityadavcloud
left a comment
There was a problem hiding this comment.
-1 - we've GitHub actions for this, and I don't expect people to run it manually on their systems.
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
I actually would expect seasoned developers to run this depending on the kind of changes they are making. that is to say the checks. if we add them to the pom file somehow that could work as well. |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
3 participants
https://pre-commit.com/#4-optional-run-against-all-the-files
https://pre-commit.com/#3-install-the-git-hook-scripts
https://pre-commit.com/#pre-commit-autoupdate
Description
The Makefile will contain the three main commands for using pre-commit locally.
At least this gives you a quickstart and place to see and run the pre-commit commands.
Makefiles can be very handy perhaps in future more commands can be added.
https://en.wikipedia.org/wiki/Make_(software)
refs apache/sedona#1183
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?